Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gateway restart during rp predeploy #3071

Merged
merged 2 commits into from
Jul 31, 2023
Merged

remove gateway restart during rp predeploy #3071

merged 2 commits into from
Jul 31, 2023

Conversation

rajdeepc2792
Copy link
Collaborator

@rajdeepc2792 rajdeepc2792 commented Jul 28, 2023 •
edited
Loading

Which issue this PR addresses:

Jira - https://issues.redhat.com/browse/ARO-3240

Fixes

What this PR does / why we need it:

Remove the gateway restart during the predeploy which was added as part of PR #2946 because the rotated encryptions secrets are not used by gateway and the gateway service doesn't need the restart during predeploy

Test plan for issue:

Updated Unit Test Cases

Is there any documentation that needs to be updated for this PR?

No

@rajdeepc2792 rajdeepc2792 added ready-for-review chainsaw Pull requests or issues owned by Team Chainsaw labels Jul 28, 2023
cadenmarchese
cadenmarchese reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick work @rajdeepc2792 !

pkg/deploy/predeploy.go Show resolved Hide resolved
pkg/deploy/predeploy.go Outdated Show resolved Hide resolved
petrkotas
petrkotas approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@petrkotas petrkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@petrkotas petrkotas merged commit 058a214 into Azure:master Jul 31, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrkotas petrkotas petrkotas approved these changes

@cadenmarchese cadenmarchese cadenmarchese approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@facchettos facchettos Awaiting requested review from facchettos

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@s-amann s-amann Awaiting requested review from s-amann

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@ellis-johnson ellis-johnson Awaiting requested review from ellis-johnson

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

Assignees
No one assigned
Labels
chainsaw Pull requests or issues owned by Team Chainsaw ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajdeepc2792 @petrkotas @cadenmarchese